Kate ([info]kate_nepveu) wrote,
@ 2006-05-19 21:54:00
Previous Entry  Add to memories!  Tell a Friend  Next Entry
Entry tags:lj

S2 nattering

Some comments on modifications to my journal style, for my own reference mostly.

I do 95% of my customizable LJ reading on the friends page, so the goal was to get it as skimmable as possible.

The style currently in use is here: http://www.livejournal.com/customize/advanced/layersource.bml?id=7945668&fmt=html.

I've made the following changes from the version [info]rilina sent me:

  • In S1, the date only displayed when it changed; in S2, it has to be displayed on every post if at all. My S1 style had the date in red, but in S2 that was too much date information, overwhelming more important stuff. So I moved the subject line to the top in red, and set up the CSS so the subject line, the poster (if on the friends page), and the number of comments are on a vertical line.
  • Removed color and underlining from links to tags in individual posts, because they were distracting.
  • De-bolded "mood" and "music" for the same reason.
  • Added conditional display of "(no subject)".
  • Made display of "add a comment" conditional on there being no comments. ETA: further modified because original code broke the layout when a post's comments were disabled.
  • Modified the skiplinks (previous, next) so that they were bracketed as a unit, not individually. Left-justified them to the main column since they can't be centered across the whole page.
  • ETA: sidebar edits: added link to website; modified style of active location.
  • Used "replace_text" to turn line breaks in auto-formatted entries into paragraph tags, and then indented the first lines of paragraphs (except in blockquotes). It's not perfect, but I think it looks better the vast majority of the time.
  • ETA: show poster name when viewing community pages in my style.

Comments or suggestions (especially how I can get the read-comments link to go to #comments, as I could in S2 managed, thanks to [info]ckd) are welcomed. Thanks again to [info]rilina.


(11 comments) - (Post a new comment)


[info]jimtbari
2006-05-20 06:04 am UTC (link)

To keep voice posts from messing things up, you probably want to change: 

## print the entry body, replacing line breaks with paragraph tags so they can be indented

 var string replaced_text = replace_text ($e.text,"<br /><br />","</p><p>");

"""<div class="entrytext"><p>$replaced_text</p></div>""";
To: 
## print the entry body, if possible replacing line breaks with paragraph tags so they can be indented


 """<div class="entrytext"><p>""";
 if ($e.text_must_print_trusted) {
     $e->print_text();
 }
 else {
     var string replaced_text = replace_text ($e.text,"<br /><br/>","</p><p>");
     print $replaced_text
 }
 """</p></div>""";
.

Hmm, #comments...another comment for that (if I get to it; my laptop has 15 minutes left and since my wife is using me as a pillow I can't easily charge it...)

(Reply to this) (Thread)

[info]jimtbari
2006-05-20 06:08 am UTC (link)
Oh, and the same thing in EntryPage::print_comment (though you don't need an if there).

And I've been given the ten minute warning, and it's two o'clock anyway. So that's all for tonight.

(Reply to this) (Parent)

[info]kate_nepveu
2006-05-20 11:40 am UTC (link)
What else does this affect? Because I don't surf with plugins on (Opera lets me change that very quickly, and so this keeps me from seeing a lot of ads and other annoyances), so the voice post thing doesn't affect me.

Thanks.

(Reply to this) (Parent)(Thread)

[info]jimtbari
2006-05-20 03:02 pm UTC (link)
Nothing else that I know of, though in theory they could add more later. If it's not affecting you (I had thought it was before your browser got to it), then don't worry about it. If it does, you know where to find the fix.

(Reply to this) (Parent)

[info]kate_nepveu
2006-05-26 06:08 pm UTC (link)
You were right and I was wrong, with the minor addition of a ; after print $replaced_text . Thanks.

(Reply to this) (Parent)

[info]ckd
2006-05-20 08:37 pm UTC (link)
Here's what I did to get the read-comments link to go to #comments (and then made it pointless by changing off the old style comment pages, and haven't fixed my entry pages yet, sigh...cobbler's kids).

function CommentInfo::print_readlink {
    var Page p = get_page();
    "<a href=\"$.read_url#comments\">"+
        get_plural_phrase($.count, $p.view == "friends" ? 
                          "text_read_comments_friends" : "text_read_comments")+
    "</a>";
}

(Reply to this) (Thread)

[info]kate_nepveu
2006-05-20 11:32 pm UTC (link)
Okay, sorry for two comments in a row where pre failed to work. Screw posting code snippets.

Anyway, I'm using function CommentInfo::print to print two things in a row, so that the comment links are in the same list, and I'm not sure how to incorporate this without breaking the layout, so I'll wait and see if there are other options.

(Reply to this) (Parent)(Thread)

[info]ckd
2006-05-21 12:18 am UTC (link)
You should be able to just paste the function I'm using into the layout right before your CommentInfo::print.

Basically, CommentInfo::print calls the print_postlink and print_readlink functions; postlink isn't changed at all, and readlink just returns a slightly modified href.

(Reply to this) (Parent)(Thread)

[info]kate_nepveu
2006-05-21 12:24 am UTC (link)
Well, so I can. Whaddya know.

Thanks--cargo-culting it has clear limits, obviously, and I appreciate the explanation.

(Reply to this) (Parent)(Thread)

[info]ckd
2006-05-21 12:35 am UTC (link)
Yeah. My RSI has shifted me from concise through terse and all the way to laconic when explaining things in text; unfortunately, that can make it difficult for folks to understand what I'm trying to say when there isn't enough shared info/knowledge about a particular item. At least face to face I have a chance of noticing that someone's not following me.

I think S2 was written by (and therefore for) people who have been writing Perl code for at least five years, which seems like a fairly good way for the audience to be limited to insane geek types (a category that I can't really exclude myself from). Sigh.

(Reply to this) (Parent)(Thread)

[info]kate_nepveu
2006-05-21 12:46 am UTC (link)
If only they'd been bought by Six Apart a little sooner, we might have a template-based system now . . .

Sorry about the RSI, but you weren't being unreasonable.

(Reply to this) (Parent)

(11 comments) - (Post a new comment)

Create an Account
Forgot your login or password?
Login w/ OpenID
English • Español • Deutsch • Русский…